Had to take out two function from Basehandler to get cmake to compile the code, should take to Dinant about this

Member ChuteWithHopper::ChuteWithHopper (Chute &other)

This copy construct is untested

Member ChuteWithHopper::create_inflow_particle ()

for periodic walls this should be only minus one particle radius, this should be fixed at some point. Thomas' response: using one particle radius gives problems when the wall is not orthogonal to the y-direction; the distance has to be slightly higher than one; if you can figure out the exact value, then correct it please.

Member ChuteWithHopperAndInset::ChuteWithHopperAndInset (Chute &other)

This copy construct is untested

Member ChuteWithHopperAndInset::create_inflow_particle ()

for periodic walls this should be only minus one particle radius, this should be fixed at some point.

Class CSpecies

Segfault, caused by: In MD::add_Species(...) (MD.cc, line 1298), if the line Species.push_back(S); causes a reallocation of internal storage, then the existing elements of Species are copy-constructed into the new memory. However, the copy constructor of CSpecies (CSpecies.h, line 35), does not copy the MixedSpecies vector, so if we call add_Species more than once (meaning that for the second and subsequent calls, existing elements in the Species vector have non-empty MixedSpecies vectors) we are liable to lose this data. Fix: Copy the MixedSpecies member in the copy constructor (CSpecies.h, line 40-ish): MixedSpecies = S.MixedSpecies; However, it looks to me as though if this line is added, the copy constructor could be replaced by the default bitwise copy constructor, so perhaps the copying of MixedSpecies has been left out for a reason...

Member HGrid::reset_num_buckets (int new_num_buckets)

{I don't know if this function still works since we do not use (m/c)alloc anymore}

Member HGRID_2D::CheckCell (int x, int y, int l, BaseParticle *obj, HGrid *grid)

{TW: This check is not necessary, I believe. This is the most-expensive function in most codes (the two checks in this function slows down granular jet by 15%) and the selftests are not affected. DK: I do think this is neccesary, for example: If two cells hash to the same bucket and a particle in one of these cells check for collisions with the other cell. Then due to the hashingcollision it also gets all particles in it's own cell and thus generating false collisions.}

Member HGRID_2D::CheckCell_current (int x, int y, int l, HGrid *grid)

{TW: This check is not necessary, I believe. This is the most-expensive function in most codes (the two checks in this function slows down granular jet by 15%) and the selftests are not affected. DK: I do think this is neccesary, for example: If two cells hash to the same bucket and a particle in one of these cells check for collisions with the other cell. Then due to the hashingcollision it also gets all particles in it's own cell and thus generating false collisions.}

Member HGRID_3D::CheckCell (int x, int y, int z, int l, BaseParticle *obj, HGrid *grid)

{TW: This check is not necessary, I believe. This is the most-expensive function in most codes (the two checks in this function slows down granular jet by 15%) and the selftests are not affected. DK: I do think this is neccesary, for example: If two cells hash to the same bucket and a particle in one of these cells check for collisions with the other cell. Then due to the hashingcollision it also gets all particles in it's own cell and thus generating false collisions.}

Member HGRID_3D::CheckCell_current (int x, int y, int z, int l, HGrid *grid)

{TW: This check is not necessary, I believe. This is the most-expensive function in most codes (the two checks in this function slows down granular jet by 15%) and the selftests are not affected. DK: I do think this is neccesary, for example: If two cells hash to the same bucket and a particle in one of these cells check for collisions with the other cell. Then due to the hashingcollision it also gets all particles in it's own cell and thus generating false collisions.}

Member HGRID_3D::HGRID_3D (MD &other)

Why is the constructor call commented out. This does not make sence to be Anthony. Dinant: I think this has something to do with somebody copying a 2D MD problem into a 3D Hgrid, then the 3D_Hgrid constructor changes properties of the MD class. Solution in my opinion is to change the HGRID_3D::constructor()

Class MD

When restarting the first time step is not saved, therefore there is a missing time step after a restart

Member MD::solve ()

This CmakeDeftions is current not included and should be readded. Currectly cause a strange compliler error, which I (Ant) do not follow

Member operator<< (std::ostream &os, const StatType S)

{The code should also be able to handle 0 particles; right now it gives an error}